Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(poolmanager): GetPoolDenoms method on PoolI for SQS #6863

Merged
merged 8 commits into from
Nov 21, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Nov 11, 2023

Closes: #XXX

What is the purpose of the change

Add GetPoolDenoms on PoolI interface in the poolmanager. Provide implementations for each pool.

This is useful for SQS.

@p0mvn p0mvn marked this pull request as draft November 11, 2023 01:04
@p0mvn p0mvn marked this pull request as ready for review November 11, 2023 01:07
@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v20.x backport patches to v20.x branch labels Nov 11, 2023
@p0mvn p0mvn closed this Nov 11, 2023
@p0mvn p0mvn reopened this Nov 11, 2023
@p0mvn p0mvn closed this Nov 11, 2023
@p0mvn p0mvn reopened this Nov 11, 2023
Copy link
Member Author

p0mvn commented Nov 11, 2023

@Mergifyio refresh

@czarcas7ic czarcas7ic closed this Nov 11, 2023
@czarcas7ic czarcas7ic reopened this Nov 11, 2023
@github-actions github-actions bot added C:x/gamm Changes, features and bugs related to the gamm module. C:x/concentrated-liquidity C:x/poolmanager labels Nov 11, 2023
Copy link
Contributor

mergify bot commented Nov 11, 2023

refresh

✅ Pull request refreshed

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, please take a look!

@@ -2,7 +2,7 @@ package types

import (
sdk "github.com/cosmos/cosmos-sdk/types"
proto "github.com/cosmos/gogoproto/proto"
proto "github.com/gogo/protobuf/proto"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what's the reason we're changing this from cosmos' gogo proto to the original one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, we need to switch this back, good catch (was likely merge conflict)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

x/cosmwasmpool/model/store_model.go Show resolved Hide resolved
x/poolmanager/types/pool.go Show resolved Hide resolved
@czarcas7ic
Copy link
Member

Mentioning here that I had issues with this method for cwpools on mainet

@p0mvn
Copy link
Member Author

p0mvn commented Nov 21, 2023

Mentioning here that I had issues with this method for cwpools on mainet

What was the solution to the issue?

@czarcas7ic
Copy link
Member

@p0mvn I just changed the GetPools method on the cwpool side to return the keeper as well. It's in my draft PR for implementing the route query

@p0mvn
Copy link
Member Author

p0mvn commented Nov 21, 2023

@p0mvn I just changed the GetPools method on the cwpool side to return the keeper as well. It's in my draft PR for implementing the route query

OK, thanks for getting back. I will then merge this, and let you fix the issue in your PR.

@p0mvn
Copy link
Member Author

p0mvn commented Nov 21, 2023

OK tests added

@p0mvn p0mvn merged commit 4c54425 into main Nov 21, 2023
1 check passed
@p0mvn p0mvn deleted the roman/denoms-pooli branch November 21, 2023 05:08
mergify bot pushed a commit that referenced this pull request Nov 21, 2023
* refactor(poolmanager): GetPoolDenoms method on PoolI for SQS

* changelog

* mocks

* change proto dep

* transmuter pool

* cfmm test

* CL test

(cherry picked from commit 4c54425)

# Conflicts:
#	CHANGELOG.md
p0mvn added a commit that referenced this pull request Nov 21, 2023
…#6863) (#6902)

* refactor(poolmanager): GetPoolDenoms method on PoolI for SQS (#6863)

* refactor(poolmanager): GetPoolDenoms method on PoolI for SQS

* changelog

* mocks

* change proto dep

* transmuter pool

* cfmm test

* CL test

(cherry picked from commit 4c54425)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Roman <[email protected]>
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge A:backport/v20.x backport patches to v20.x branch C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/poolmanager V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants